Ticket #132 (assigned defect)

Opened 8 years ago

Last modified 8 years ago

sort on thumbnails

Reported by: gurman Owned by: joe
Priority: normal Milestone:
Component: UserInterface Version: 1.2
Severity: normal Keywords:
Cc:

Description

     I also found that "sort" doesn't work on the Thumbnail column ---
too bad, since I wanted to eliminate all the Yohkoh Legacy FITS
files, and just get the "old" format files we archive here (for now).

Change History

comment:1 Changed 8 years ago by joe

  • Status changed from new to assigned

modified GQuery.pm, VSO::UI::Thumbs::cmp, so it returns -1/0/1, sorted on URL, but blanks/undef go at the end.

Need to push to production.

comment:2 Changed 8 years ago by gurman

>      Thanks. Looks like it's sorting by the Thumbnail column by
> default, which sort of makes sense as it's the first column, and
> easily changed to sort by start time, but it may not be the "natural"
> choice --- start time is probably more likely it. We can poll the
> team members.

comment:3 Changed 8 years ago by joe

Okay ... a few modifications ... in VSOUIBase.pm :

VSO::UI::View : 'getViewArray' and '_readOrderArray' take an extra argument, which is a flag to request sort order, rather than display order ... only required changing a few lines ... so that 'currentSortIOrder' gets initialized slightly differently.

In the object using VSOUIBase (eg, VSOUI.pm), when you call createViews, append an extra (optional) item for a 'sort order' that is different from 'display order'. (if not set, assumes display order == sort order)

In QA on vso1; hasn't been committed to CVS.

Note: See TracTickets for help on using tickets.